Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update release script #1913

Merged
merged 4 commits into from Oct 10, 2020
Merged

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

Did you add tests for your changes?

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

anshumanv
anshumanv previously approved these changes Oct 10, 2020
@anshumanv
Copy link
Member

wrong branch?

@alexander-akait
Copy link
Member Author

alexander-akait commented Oct 10, 2020

@anshumanv no, I merged next into master

@anshumanv
Copy link
Member

Gotcha I thought we'll make master as v3 and make next as master, how do we access v3 code?

@alexander-akait
Copy link
Member Author

we don't need v3 anymore 😄 we have v4

@alexander-akait
Copy link
Member Author

Anyway we can create v3 branch using git checkout, but I think it is unnecessary

@alexander-akait
Copy link
Member Author

We need looking for how we can speed up our build, because wait 30 minutes is very very very long 😞

@alexander-akait alexander-akait merged commit b78463a into master Oct 10, 2020
@alexander-akait alexander-akait deleted the chore-update-release-script branch October 10, 2020 17:56
@anshumanv
Copy link
Member

We validate full schema and every single flag on 3 platforms with 3 node version so I'm not surprised 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants