Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --analyze flag #1853

Merged
merged 5 commits into from Oct 6, 2020
Merged

feat: add --analyze flag #1853

merged 5 commits into from Oct 6, 2020

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
Feature

Did you add tests for your changes?
WIP
If relevant, did you update the documentation?
WIP
Summary

Invoke webpack-bundle-analyzer plugin via --analyze flag.

Does this PR introduce a breaking change?
No

Other information
Fixes #1838

@snitin315 snitin315 marked this pull request as ready for review October 3, 2020 06:10
@snitin315 snitin315 requested a review from a team as a code owner October 3, 2020 06:10
alexander-akait
alexander-akait previously approved these changes Oct 3, 2020
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

/cc @webpack/cli-team

@snitin315
Copy link
Member Author

Timeout error on windows CI 😞 .

@alexander-akait
Copy link
Member

execa sometimes buggy on windows, do you have windows?

@snitin315
Copy link
Member Author

Not me, Anyone else with windows @webpack/cli-team ?

evenstensberg
evenstensberg previously approved these changes Oct 4, 2020
alexander-akait
alexander-akait previously approved these changes Oct 5, 2020
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@webpack-bot
Copy link

@snitin315 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evilebottnawi Please review the new changes.

error(`It looks like ${yellow('webpack-bundle-analyzer')} is not installed.`);
process.exitCode = 2;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we ask to install webpack-bundle-analyzer here?

Copy link
Member Author

@snitin315 snitin315 Oct 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will update.

@snitin315
Copy link
Member Author

/cc @webpack/cli-team

@rishabh3112 rishabh3112 merged commit e6d210a into next Oct 6, 2020
@rishabh3112 rishabh3112 deleted the feat/analyze-flag branch October 6, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support webpack-bundle-analyzer with CLI
5 participants