fix: check webpack installation before running cli #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let cli = undefined; | ||
| if (packageExists('webpack')) { | ||
| cli = require('webpack').cli; | ||
| } |
There was a problem hiding this comment.
Can be refactored as -> const cli = packageExists('webpack') ? require('webpack').cli : undefined
Else we get Error: can't find module 'webpack'
| @@ -4,13 +4,21 @@ | |||
| require('v8-compile-cache'); | |||
| const importLocal = require('import-local'); | |||
| const runCLI = require('../lib/bootstrap'); | |||
| const { yellow } = require('colorette'); | |||
| const { packageExists, promptInstallation } = require('@webpack-cli/package-utils'); | |||
There was a problem hiding this comment.
Do we add package-utils in deps?
There was a problem hiding this comment.
Yes Already present.
There was a problem hiding this comment.
But these utils are only being used by webpack-cli, So we can safely move it from package-utils to utils. Let's do this in separate PR.
ylemkimon
reviewed
Sep 24, 2020
snitin315
force-pushed
the
fix/check-webpack-installation
branch
from
8471606
to
36e75ab
Compare
snitin315
force-pushed
the
fix/check-webpack-installation
branch
from
36e75ab
to
eecd833
Compare
alexander-akait
approved these changes
Sep 25, 2020
rishabh3112
approved these changes
Sep 25, 2020
|
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @rishabh3112 Please review the new changes. |
anshumanv
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
no
If relevant, did you update the documentation?
no
Summary
prompt to install
webpackif it's not present already.Does this PR introduce a breaking change?
No
Other information
Refers #1383 (comment)
Fixes #1383