Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup package-utils package #1822

Merged
merged 12 commits into from Oct 10, 2020
Merged

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?

refactor

Did you add tests for your changes?
Migrated tests

If relevant, did you update the documentation?
NA

Summary

  • This removes the package package-utils which was kinda redundant since we already had utils package

Does this PR introduce a breaking change?
Shouldn't

Other information

Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion

packages/webpack-cli/package.json Outdated Show resolved Hide resolved
@anshumanv anshumanv marked this pull request as ready for review October 9, 2020 17:13
@anshumanv anshumanv requested a review from a team as a code owner October 9, 2020 17:13
@anshumanv anshumanv changed the title refactor: cleanup package-utils package fix: cleanup package-utils package Oct 9, 2020
alexander-akait
alexander-akait previously approved these changes Oct 9, 2020
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@alexander-akait
Copy link
Member

/cc @webpack/cli-team need review

@anshumanv anshumanv merged commit fd5b92b into webpack:next Oct 10, 2020
@anshumanv anshumanv deleted the rm/package-utils branch October 10, 2020 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants