-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webpack-cli@4.0.0-beta.1 still (transitively) depends on webpack@4.x.x #1163
Comments
I think #1148 would solve this issue too @ematipico |
I think too |
Thanks folks. Just so I understand - should I just wait for that PR to be merged (it looks like maybe its blocked by the build failures on next at the moment?) or should I try to make another PR that addresses it now? |
@tlmii the PR has been merged. This should be available in next release. |
@rishabh3112 Is there a target date for a beta 2? Saw the roadmap but couldn't find a schedule. |
/cc @ematipico |
I might be able to ship a new beta this week. Maybe. |
@tlmii new version of beta is released, you may check now. |
This looks good. Thanks folks! |
Describe the bug
Installing webpack-cli@4.0.0-beta.1 still adds the latest webpack @4.x.x to the node_modules folder, even though it directly depends on webpack@^5.0.0-beta.3.
The dependency comes to play via
webpack-cli -> @webpack-cli/init -> @webpack-cli/generators webpack@4.x.x
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I would expect it to only need the already-installed 5.0.0-beta.11.
Additional context
I'm trying to avoid an issue with fsevents@1.2.11, which is an optional transitive dependency of webpack@4 (
webpack -> watchpack -> chokidar -> fsevents
). I'm willing to move to the beta of webpack 5 for this particular project, but I'm running into this issue with webpack-cli. With that version of fsevents being dropped into node_modules, I can't ever runnpm ci
, even though we don't actually use anything that would be impacted.The text was updated successfully, but these errors were encountered: