From ae9539d20eab2172118f61f7a9ba7e26541e16a2 Mon Sep 17 00:00:00 2001
From: Nitin Kumar <snitin315@gmail.com>
Date: Mon, 5 Oct 2020 21:19:42 +0530
Subject: [PATCH] fix: warning should not result in non-zero exit code (#1872)

Co-authored-by: James George <jamesgeorge998001@gmail.com>
---
 README.md                                       | 2 +-
 packages/webpack-cli/lib/utils/Compiler.js      | 2 +-
 test/loader/warning-test/loader-warning.test.js | 2 +-
 test/loader/warning-test/webpack.config.js      | 3 +++
 4 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index aa61769919b..7e2ee92c7f4 100644
--- a/README.md
+++ b/README.md
@@ -102,7 +102,7 @@ You can read more about [Scaffolding](https://webpack.js.org/guides/scaffolding)
 | Exit Code | Description                                        |
 | --------- | -------------------------------------------------- |
 | `0`       | Success                                            |
-| `1`       | Warnings/Errors from webpack                       |
+| `1`       | Errors from webpack                                |
 | `2`       | Configuration/options problem or an internal error |
 
 ## Contributing and Internal Documentation
diff --git a/packages/webpack-cli/lib/utils/Compiler.js b/packages/webpack-cli/lib/utils/Compiler.js
index 4a8c8457c37..e02f8128e3c 100644
--- a/packages/webpack-cli/lib/utils/Compiler.js
+++ b/packages/webpack-cli/lib/utils/Compiler.js
@@ -53,7 +53,7 @@ class Compiler {
             logger.error(err.stack || err);
             process.exit(1); // eslint-disable-line
         }
-        if (!outputOptions.watch && (stats.hasErrors() || stats.hasWarnings())) {
+        if (!outputOptions.watch && stats.hasErrors()) {
             process.exitCode = 1;
         }
         if (outputOptions.json === true) {
diff --git a/test/loader/warning-test/loader-warning.test.js b/test/loader/warning-test/loader-warning.test.js
index 106e6afb8b0..ce69e697f09 100644
--- a/test/loader/warning-test/loader-warning.test.js
+++ b/test/loader/warning-test/loader-warning.test.js
@@ -8,6 +8,6 @@ describe('loader warning test', () => {
 
         expect(stdout).toContain('[1 warning]');
         expect(stdout).toContain('This is a warning');
-        expect(exitCode).not.toEqual(0);
+        expect(exitCode).toEqual(0);
     });
 });
diff --git a/test/loader/warning-test/webpack.config.js b/test/loader/warning-test/webpack.config.js
index ce43c65a673..15f03beb9c8 100644
--- a/test/loader/warning-test/webpack.config.js
+++ b/test/loader/warning-test/webpack.config.js
@@ -27,4 +27,7 @@ module.exports = {
             'my-loader': require.resolve('./my-loader'),
         },
     },
+    performance: {
+        hints: 'warning',
+    },
 };