From a7e1a8e94a74d0081db5e15b8a9687f21bd7980f Mon Sep 17 00:00:00 2001 From: Nitin Kumar Date: Mon, 5 Oct 2020 10:27:40 +0530 Subject: [PATCH] fix: warning should not result in non-zero exit code --- packages/webpack-cli/lib/utils/Compiler.js | 2 +- test/loader/warning-test/loader-warning.test.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/webpack-cli/lib/utils/Compiler.js b/packages/webpack-cli/lib/utils/Compiler.js index 0479354a624..fefb72e3178 100644 --- a/packages/webpack-cli/lib/utils/Compiler.js +++ b/packages/webpack-cli/lib/utils/Compiler.js @@ -56,7 +56,7 @@ class Compiler { logger.error(err.stack || err); process.exit(1); // eslint-disable-line } - if (!outputOptions.watch && (stats.hasErrors() || stats.hasWarnings())) { + if (!outputOptions.watch && stats.hasErrors()) { process.exitCode = 1; } if (outputOptions.json === true) { diff --git a/test/loader/warning-test/loader-warning.test.js b/test/loader/warning-test/loader-warning.test.js index 106e6afb8b0..ce69e697f09 100644 --- a/test/loader/warning-test/loader-warning.test.js +++ b/test/loader/warning-test/loader-warning.test.js @@ -8,6 +8,6 @@ describe('loader warning test', () => { expect(stdout).toContain('[1 warning]'); expect(stdout).toContain('This is a warning'); - expect(exitCode).not.toEqual(0); + expect(exitCode).toEqual(0); }); });