Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSP check is reporting vulnerability on latest Webpack package. #63

Closed
webpack-bot opened this issue Feb 22, 2018 · 12 comments
Closed

NSP check is reporting vulnerability on latest Webpack package. #63

webpack-bot opened this issue Feb 22, 2018 · 12 comments

Comments

@webpack-bot
Copy link

Do you want to request a feature or report a bug?

What is the current behavior?

If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?

If this is a feature request, what is motivation or use case for changing the behavior?

Please mention other relevant information such as the browser version, Node.js version, webpack version, and Operating System.

Just executed the nsp check command on my project and it is reporting a vulnerability on latest webpack package due to a downstream dependency on the module hoek.
Please refer the link from node security: https://nodesecurity.io/advisories/566

Path: webpack >> watchpack@1.4.0>>chokidar@1.7.0>>fsevents@1.1.3>>node-pre-gyp@0.6.39>>hawk>>hoek


This issue was moved from webpack/webpack#6513 by @evilebottnawi. Orginal issue was by @sneharghya.

@evenstensberg
Copy link
Member

mozilla/hawk#234

@EugeneHlushko
Copy link
Member

in that case it can be closed? @ev1stensberg

@evenstensberg
Copy link
Member

That's not for me to decide

@realityking
Copy link
Contributor

The problem is that fsevents bundles node-pre-gyp. See fsevents/fsevents#187 for details.

@stoikerty
Copy link

Is there an update on this by any chance?

Looks like the issue in fsevents has been resolved in v1.2.0
fsevents/fsevents#187 (comment)

fsevents has been updated to v1.2.2 just 18hrs ago

@alexander-akait
Copy link
Member

@stoikerty hm, why don't update npm/yarn lock files?

@lysla
Copy link

lysla commented May 26, 2018

Any news about this issue? Just started a new repo with fresh webpack setup and github is notifying me with the vulnerability issue on Hoek v2.16.3 in package lock dependencies. Should I just ignore it at the moment?

@evenstensberg
Copy link
Member

Could you try to open an issue at the Hawk repository?

@alexander-akait
Copy link
Member

@lysla looks you use webpack global and should reinstall, issue was fixed, just update you deps and lock files (also update webpack globally if you install globally)

@lysla
Copy link

lysla commented May 28, 2018

@evilebottnawi i did not install webpack globally, i installed it in the local directory of a new project, was a fresh install. i will try to update (?) as in uninstall - re-install...

@alexander-akait
Copy link
Member

@lysla yes, we every day install and reinstall webpack and no problem, also can you provide webpack version?

@lysla
Copy link

lysla commented May 28, 2018

@evilebottnawi i did reinstall and then checked on packagelock deps, it turns out for me this was related to node-sass and not actually webpack, they currently have an open issue here sass/node-sass#2355 - waiting for node-sass v5 to be realeased then... sorry for the trouble ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants