Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve watcher update performance #208

Merged
merged 1 commit into from Nov 24, 2021
Merged

improve watcher update performance #208

merged 1 commit into from Nov 24, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Nov 24, 2021

measurements show a 13x improvement

@sokra sokra closed this Nov 24, 2021
@sokra sokra reopened this Nov 24, 2021
@sokra sokra closed this Nov 24, 2021
@sokra sokra reopened this Nov 24, 2021
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #208 (dec2905) into main (0d90321) will decrease coverage by 0.53%.
The diff coverage is 86.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   92.58%   92.05%   -0.54%     
==========================================
  Files           6        6              
  Lines        1039     1070      +31     
  Branches      246      258      +12     
==========================================
+ Hits          962      985      +23     
- Misses         77       85       +8     
Flag Coverage Δ
integration 92.05% <86.84%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/watchpack.js 92.21% <86.84%> (-2.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d90321...dec2905. Read the comment docs.

@sokra sokra merged commit 523793e into main Nov 24, 2021
@sokra sokra deleted the perf/update-watchers branch November 24, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant