fix: adds ENOENT for non windows platforms in LinkResolver. #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aghassi
force-pushed
the
fix/enoent-throwing
branch
from
c630a6d
to
21b63c7
Compare
|
Sure thing, let me dig into the tests today and see where I can add a test for this |
Aghassi
force-pushed
the
fix/enoent-throwing
branch
from
21b63c7
to
b78cbf1
Compare
Solves for use case where Webpack is running under Bazel with iBazel. Heavily relies on symlinks set up in a certain way See bazelbuild/rules_nodejs#2431
sokra
force-pushed
the
fix/enoent-throwing
branch
from
b78cbf1
to
7684df0
Compare
sokra
approved these changes
Feb 7, 2021
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves for use case where Webpack is running under Bazel
with iBazel. Heavily relies on symlinks set up in a certain way.
Essentially we don't want Webpack to follow symlinks, but we do want the watcher
to follow symlinks. In that setup, it causes an
ENOENTwhich does not fall through inwatchpack under
darwinas the platform (or linux for that matter). This fixes that case.See bazelbuild/rules_nodejs#2431
CC @sokra @gregmagolan @mrmeku