Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ReDoS problem #224

Merged
merged 2 commits into from Nov 11, 2022
Merged

fix: ReDoS problem #224

merged 2 commits into from Nov 11, 2022

Conversation

alexander-akait
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 76.66% // Head: 76.66% // No change to project coverage 👍

Coverage data is based on head (40f4345) compared to base (52cd134).
Patch has no changes to coverable lines.

❗ Current head 40f4345 differs from pull request most recent head 77b0530. Consider uploading reports for the commit 77b0530 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   76.66%   76.66%           
=======================================
  Files          10       10           
  Lines         360      360           
  Branches      112      112           
=======================================
  Hits          276      276           
  Misses         73       73           
  Partials       11       11           
Impacted Files Coverage Δ
lib/interpolateName.js 95.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait alexander-akait merged commit d2d752d into master Nov 11, 2022
@alexander-akait alexander-akait deleted the fix-security-problem branch November 11, 2022 00:24
@@ -76,7 +76,7 @@ function interpolateName(loaderContext, name, options = {}) {
// `hash` and `contenthash` are same in `loader-utils` context
// let's keep `hash` for backward compatibility
.replace(
/\[(?:([^:\]]+):)?(?:hash|contenthash)(?::([a-z]+\d*))?(?::(\d+))?\]/gi,
/\[(?:([^[:\]]+):)?(?:hash|contenthash)(?::([a-z]+\d*))?(?::(\d+))?\]/gi,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this don't need translation? \[

Copy link

@heatherleeann heatherleeann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants