Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier show all files with error because of default #203

Closed
peter-spireng opened this issue Jan 25, 2022 · 3 comments · Fixed by #204
Closed

Prettier show all files with error because of default #203

peter-spireng opened this issue Jan 25, 2022 · 3 comments · Fixed by #204

Comments

@peter-spireng
Copy link
Contributor

Clone repository and run "yarn test" - prettier will show error in files because of end of lines. There is no prettier config, so it expect "lf" on end of line (from version 2.0.0 - https://prettier.io/docs/en/options.html#end-of-line) but currenty there is "crlf" in files.
I can prepare PR but what is right option: add .prettierrc with "crlf" end of line configuration value or change end of line in source files to "lf"?

@alexander-akait
Copy link
Member

We use lf, I think something wrong with .gitattributes

@peter-spireng
Copy link
Contributor Author

I dont see any .gitattributes file in loader-utils repo ... probably we should add it

@alexander-akait
Copy link
Member

Yes, we should add, feel free to send a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants