Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent blocked words in generated hash #156

Open
jens-duttke opened this issue Nov 18, 2019 · 0 comments
Open

Prevent blocked words in generated hash #156

jens-duttke opened this issue Nov 18, 2019 · 0 comments

Comments

@jens-duttke
Copy link

The most Adblockers block resources if they contain specific words in the file name.

While creating hashes for file names, this should be considered to make sure, resulting files don't get blocked, because of their filename.

Some examples of blocked patterns from the popular EasyList filter list:

.120x600.
120-600.gif|
.160x600.
160x600.jpg|
.300x250.
.468x60.
700_200.jpg|
.clkads.
.cyad1.
.intad.
.internads.
.mobileads.
.nativeads.
.popupvideoad.
.refreshAds.
.rolloverad.
.sponsorads.
.streamads.
.textads.
.theadtech.
.topad.
.videoad3.
.videoad4.

For the above patterns, we can deduce that atleast /(ad|\d{2,}[x_-]\d{2,})/i should be avoided.

Children projection filters may also filter files if their name contains words like "sex", "porn", "p0rn", "fuck", "shit", "tits", "suck", "wank", "anal", "penis" etc.

I think this should be considered a problem, since the number of adblock users is very high:
https://www.quora.com/What-percent-of-internet-users-use-adblock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant