This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
fix(index): use path.posix for platform consistency
#254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to have some tests for this? It's frustrating to have these kind of regressions on Windows, having tests would of avoided this. I'm a total webpack noob so not sure how you would go about testing it but would be cool if there was! 😄 |
|
@garygreen tests already exist, we run CI on window |
michael-ciniawsky
force-pushed
the
fix/outputPath
branch
from
9d89419
to
036018d
Compare
michael-ciniawsky
added
status: Approved
and removed
pr_action: Review
priority: 2 (urgent)
severity: 2 (regression)
status: Pending
labels
This was referenced Feb 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IssuesNotable ChangesUse
path.posixinstead ofpathto avoid platform specifics of thepathmodule to keep paths consistentDependantsoptions.publicPath) #253 (Ideally lands before this PR)