Skip to content

Fix argument name in error message #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Conversation

discordier
Copy link
Contributor

The error message was referring to the path argument being not a string while it was the request argument being not a string.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
The error message was referring to the `path` argument being not a string while it was the `request` argument being not a string.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 10, 2022

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #329 (963e4db) into main (b6468e0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files          39       39           
  Lines        1594     1594           
=======================================
  Hits         1514     1514           
  Misses         80       80           
Impacted Files Coverage Δ
lib/Resolver.js 86.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6468e0...963e4db. Read the comment docs.

@sokra sokra merged commit 90aa401 into webpack:main Jun 28, 2022
@sokra
Copy link
Member

sokra commented Jun 28, 2022

Thanks

@discordier discordier deleted the patch-1 branch June 29, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants