This repository has been archived by the owner on Sep 9, 2021. It is now read-only.
fix: make inline workers work from inside workers #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
==========================================
- Coverage 76.35% 75.83% -0.52%
==========================================
Files 6 6
Lines 148 149 +1
Branches 51 52 +1
==========================================
Hits 113 113
Misses 30 30
- Partials 5 6 +1
Continue to review full report at Codecov.
|
MatthewSteel
force-pushed
the
steel/self-or-window
branch
from
a7619bf
to
15e7d72
Compare
MatthewSteel
force-pushed
the
steel/self-or-window
branch
from
15e7d72
to
9cd816e
Compare
TheLD6978
pushed a commit
to TheLD6978/worker-loader
that referenced
this pull request
Apr 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
This change enables inline workers to be instantiated from worker scopes (where
windowisn't available.)Breaking Changes
None.
Additional Info
fixes #306