This repository has been archived by the owner on Sep 9, 2021. It is now read-only.
fix(inline): move URL declaration inside the exported function
#284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to use `window` outside the function will break SSR builds
|
|
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
=======================================
Coverage 74.48% 74.48%
=======================================
Files 6 6
Lines 145 145
Branches 52 52
=======================================
Hits 108 108
Misses 31 31
Partials 6 6
Continue to review full report at Codecov.
|
TheLD6978
pushed a commit
to TheLD6978/worker-loader
that referenced
this pull request
Apr 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Trying to use
windowoutside the function will break SSR buildsBreaking Changes
none
Additional Info