feat: replace querystring with urlsearchparams #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
DraftProducts
approved these changes
Nov 20, 2021
|
What prevents this PR from being merged? @glenjamin |
|
Is this fix planned to be merged soon? @glenjamin |
glenjamin
force-pushed
the
feature/replace-querystring-with-urlsearchparams
branch
from
21c483f
to
240cd16
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
The querystring API is deprecated
Breaking Changes
changing the querystring API for the URLSearchParams API could bring breaking changes as the querystring API remove trailing characters from the params and URLSearchParams don't, but in the webpack hot middleware case, this should not be a breaking change, also the URLSearchParams API is not available in node 0.4 and below, that might be a little issue
Additional Info