improved client overlay style

[jimblue]

This PR contains a fix for #359.

Motivation

The style of the client overlay is slightly change for better readability.

Breaking Changes

This PR doesn't introduce breaking changes

Additional Info

Here are some before after screenshot of the client overlay.

WARNING
before

after

ERROR
before

after

[jsf-clabot]

All committers have signed the CLA.

[codecov]

Codecov Report

Merging #360 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   88.63%   88.63%           
=======================================
  Files           3        3           
  Lines         264      264           
  Branches       76       76           
=======================================
  Hits          234      234           
  Misses         30       30

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe33d59...e2b49ff. Read the comment docs.

[glenjamin]

I notice you changed some of the other colours too, would you mind doing a before/after on those too?

[jimblue]

I notice you changed some of the other colours too, would you mind doing a before/after on those too?

You can see it for yellow and red on the above before after. (look at the background color of the tags)
For the others colors I keep the same direction: "better readability with pop/constrasty/stylish colors".
It's a discret change put enough to give better readability.
Let me know if you need more...

[glenjamin]

I’d like to leave screenshots of all the changed colours in the issue as a historical record

Did you have some sample output you used to select the changes to the ANSI colours?

[jimblue]

Screenshots are gonna be difficult as only two colors are used in the client overlay. (red/yellow and you already have thoses screenshot)

But, what I can do on photoshop is a color palette of before after, what do you think?

[glenjamin]

How were the new ANSI colours selected? I had assumed you had some sample output which used a variety of colours and demonstrated the need for improvement

[jimblue]

Here is a visual way to show the change 😄

[glenjamin]

Perfect, thanks!

[glenjamin]

Published as v2.25.0