Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Dependency Updates #10

Open
joshwiens opened this issue Mar 3, 2017 · 5 comments
Open

RFC: Dependency Updates #10

joshwiens opened this issue Mar 3, 2017 · 5 comments

Comments

@joshwiens
Copy link
Member

joshwiens commented Mar 3, 2017

The topic of using greenkeeper.io was raised by @boopathi in Slack.

At an organization level, the amount of spam in the feed would be less than optimal to say the least but it does highlight a valid need...

  • Making the maintenance of dependencies more consistent across the organization and less tedious for maintainers.

The two viable options ...

1.) As opposed to using that particular tool, what about using https://github.com/yeoman/update-notifier as a part of defaults?

2.) Use updtr as a part of the post-install(prepare in 8.x) hook or another viable execution method to notify about dependency updates. The Updtr feature set is a nice middle ground between completely manual & something like greenkeeper.io. The caveat being that we will probably have to PR in an update for npm@5 though I haven't tested that theory yet.

Accomplishes the same thing ( less the automatic pull requests ) with none of the spam that comes along with greenkeeper.io that would be detrimental at a higher level.

//cc @bebraw @sapegin

@bebraw
Copy link
Contributor

bebraw commented Mar 4, 2017

👍 for update-notifier.

Greenkeeper is too noisy for me. That said, we need a good way to propagate changes like the one that was made to loader-utils across repositories. Tackling internal deprecations would be valuable itself.

I guess in ideal world, we would have codemods and automation to apply them on breaking changes (only review effort), but that's far off at the moment.

@sapegin
Copy link
Member

sapegin commented Mar 4, 2017

How it should work with update-notifier? Not sure I understand how you want to use it.

@joshwiens
Copy link
Member Author

joshwiens commented Mar 4, 2017

Not something you need to add immediately and the implementation details still need to be fleshed out. Issue opened based on a conversation about dependency maintenance and our general desire to not use greenkeeper.io to do it.

Usage: Run notifier as a part of ( end of realistically ) the cli execution of webpack-defaults

Not suggesting that we automatically upgrade pacakges, only that we notify that the maintainer has possible upgrades. Automatic dependency upgrade is always going to be tedious at the consumer level, a simple reminder on the defaults execution should be sufficient.

@michael-ciniawsky
Copy link
Member

@alexander-akait
Copy link
Member

@michael-ciniawsky better use renovate to automatize this process, let's open issue we should setup this in future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants