Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow self for globalObject in async chunks #323

Merged
merged 1 commit into from Oct 16, 2019
Merged

Allow self for globalObject in async chunks #323

merged 1 commit into from Oct 16, 2019

Conversation

lemonmade
Copy link
Contributor

This PR adds support for self as the globalObject when searching for async chunks. We use self for our client bundles because it supports both browsers and web workers, and we have some libraries that will create workers as child compilations of the client compile. Technically you can pass a lot more in here (as shown in #288, although more complex configuration like that is still not supported with my change), but this PR just adds auto-detection of self. Given that it is technically the default value, this seems like an appropriate inclusion to me.

@jsf-clabot
Copy link

jsf-clabot commented Oct 16, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@valscion valscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks good to me! I'll close+reopen the PR so that CLA check goes green.

Can you add a changelog entry similar to what we have before, under the "UNRELEASED" section? This is an "Improvement" change

@@ -0,0 +1 @@
(self.webpackJsonp=self.webpackJsonp||[]).push([[27],{1:function(e,n,t){console.log("Chuck Norris")}}]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@valscion valscion closed this Oct 16, 2019
@valscion valscion reopened this Oct 16, 2019
@valscion
Copy link
Member

Thanks!

@valscion valscion merged commit ea074c1 into webpack-contrib:master Oct 16, 2019
@valscion
Copy link
Member

Released in v3.6.0 ☺️

@lemonmade
Copy link
Contributor Author

❤️ Thanks so much for the quick review/ release!

@lemonmade lemonmade deleted the fix-self-global-object branch October 16, 2019 15:07
@valscion
Copy link
Member

Thanks for the contribution 😊. Happened to have a nice slot to review this PR today right as GitHub notification popped up 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants