Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsyncMFS for getBundleDirFromCompiler #275

Merged

Conversation

amoshydra
Copy link
Contributor

Details

  • Detect AsyncMFS to support dev-server of Nuxt 2.5 and above

Related issues

@jsf-clabot
Copy link

jsf-clabot commented Apr 25, 2019

CLA assistant check
All committers have signed the CLA.

@valscion
Copy link
Member

valscion commented Apr 25, 2019

I'll close and reopen the PR to trigger the CLA check again

EDIT: Yup, it worked and the CLA status went green.

@valscion valscion closed this Apr 25, 2019
@valscion valscion reopened this Apr 25, 2019
@valscion
Copy link
Member

As I said in #274, I think this is an OK tradeoff. I'm a bit wary on adding new configuration options as each new option makes the library a bit more difficult to use.

Could we add a comment above the AsyncMFS case statement to describe why that check is necessary, preferrably linking also to issue #274?

@amoshydra
Copy link
Contributor Author

Sure!

I have added comment mentioning usage of AsyncMFS in a9653ca

@amoshydra
Copy link
Contributor Author

Hi @valscion,

One of the travis-ci test is failing in Node.js 6 environment with

Error: Timeout of 15000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/travis/build/webpack-contrib/webpack-bundle-analyzer/test/analyzer.js)

This appear to be an test environment issue, since the 2 additional commits dont change the behaviour of the code. Is it possible to restart the test?

@valscion
Copy link
Member

Is it possible to restart the test?

Done, and CI is still green.

I'll let @th0r take a look at this PR to see if he's on the same page with me regarding this — if I don't hear from him in a few days I'll merge this PR as-is.

Thank you for your contributions!

@th0r
Copy link
Collaborator

th0r commented May 8, 2019

Merged, but we need to think about some better solution. Maybe we can just use this.compiler.outputFileSystem to read compiled assets and write report files.

@th0r th0r merged commit 44bd8d0 into webpack-contrib:master May 8, 2019
@amoshydra amoshydra deleted the bundledir-as-null-for-async-mfs branch May 9, 2019 04:57
@th0r
Copy link
Collaborator

th0r commented Jul 29, 2019

Published in v3.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants