Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using WebWorkerChunkTemplatePlugin generates modules in an unrecognized way #351

Closed
Gongreg opened this issue May 18, 2020 · 1 comment · Fixed by #353
Closed

Using WebWorkerChunkTemplatePlugin generates modules in an unrecognized way #351

Gongreg opened this issue May 18, 2020 · 1 comment · Fixed by #353
Labels
Status: Ready for PR type: Feature

Comments

@Gongreg
Copy link
Contributor

Gongreg commented May 18, 2020 •
edited

Issue description

While working using webpack for web-worker with chunks WebWorkerChunkTemplatePlugin The source is created in this format:

source.add(
	`${globalObject}[${JSON.stringify(
		chunkCallbackName
	)}](${JSON.stringify(chunk.ids)},`
);

So:

self["chunkCallbackName"]([9],{

or

self.chunkCallbackName([9],{

when the code is minified.

There should be a check for this.
@valscion
Copy link
Member

PR is welcome ☺️

@Gongreg Gongreg mentioned this issue May 19, 2020
Merged
@valscion valscion linked a pull request May 19, 2020 that will close this issue
Added support for Web worker chunk template plugin #353
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Ready for PR type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support for Web worker chunk template plugin Gongreg/webpack-bundle-analyzer
2 participants
@valscion @Gongreg