Support output.path interpolation #304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valscion
commented
Jul 30, 2019
| @@ -35,6 +35,7 @@ class BundleAnalyzerPlugin { | |||
|
|
|||
| const done = (stats, callback) => { | |||
| callback = callback || (() => {}); | |||
| const bundleDir = stats.compilation.getPath(stats.compilation.outputOptions.path); | |||
There was a problem hiding this comment.
I have no idea if this getPath function is a public API from webpack. And neither do I know if stats.compilation.outputOptions.path is OK to use here.
|
|
||
| await webpackCompile(config); | ||
|
|
||
| const chartData = await getChartDataFromReport('7e56a1f8a54acedcc9ce/report.html'); |
There was a problem hiding this comment.
I'm not sure if this hash is the same across different webpack versions... this might cause a very brittle test.
I don't yet have good ideas on how to figure out the hash that was used to get to the report page.
| } else if (this.opts.analyzerMode === 'static') { | ||
| actions.push(() => this.generateStaticReport(stats.toJson())); | ||
| actions.push(() => this.generateStaticReport(stats.toJson(), bundleDir)); |
There was a problem hiding this comment.
I'm not a huge fan in how I had to add another argument to these methods to get this working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #297