From 9811e035991fec36d9a46ce5695cfa2e0acd89ee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rouven=20We=C3=9Fling?= Date: Tue, 11 Sep 2018 22:58:07 +0200 Subject: [PATCH 1/4] Move packages only used in the client to dev-dependencies Fixes #208 --- package-lock.json | 14 ++++++++++---- package.json | 6 +++--- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/package-lock.json b/package-lock.json index 3e101ffd..b7b57d20 100644 --- a/package-lock.json +++ b/package-lock.json @@ -752,6 +752,7 @@ "version": "7.0.0", "resolved": "https://registry.npmjs.org/@babel/polyfill/-/polyfill-7.0.0.tgz", "integrity": "sha512-dnrMRkyyr74CRelJwvgnnSUDh2ge2NCTyHVwpOdvRMHtJUyxLtMAfhBN3s64pY41zdw0kgiLPh6S20eb1NcX6Q==", + "dev": true, "requires": { "core-js": "^2.5.7", "regenerator-runtime": "^0.11.1" @@ -2553,7 +2554,8 @@ "core-js": { "version": "2.5.7", "resolved": "https://registry.npmjs.org/core-js/-/core-js-2.5.7.tgz", - "integrity": "sha512-RszJCAxg/PP6uzXVXL6BsxSXx/B05oJAQ2vkJRjyjrEcNVycaqOmNb5OTxZPE3xa5gwZduqza6L9JOCenh/Ecw==" + "integrity": "sha512-RszJCAxg/PP6uzXVXL6BsxSXx/B05oJAQ2vkJRjyjrEcNVycaqOmNb5OTxZPE3xa5gwZduqza6L9JOCenh/Ecw==", + "dev": true }, "core-util-is": { "version": "1.0.2", @@ -5244,7 +5246,8 @@ "hoist-non-react-statics": { "version": "2.5.5", "resolved": "https://registry.npmjs.org/hoist-non-react-statics/-/hoist-non-react-statics-2.5.5.tgz", - "integrity": "sha512-rqcy4pJo55FTTLWt+bU8ukscqHeE/e9KWvsOW2b/a3afxQZhwkQdT1rPPCJ0rYXdj4vNcasY8zHTH+jF/qStxw==" + "integrity": "sha512-rqcy4pJo55FTTLWt+bU8ukscqHeE/e9KWvsOW2b/a3afxQZhwkQdT1rPPCJ0rYXdj4vNcasY8zHTH+jF/qStxw==", + "dev": true }, "home-or-tmp": { "version": "3.0.0", @@ -6572,12 +6575,14 @@ "mobx": { "version": "5.1.0", "resolved": "https://registry.npmjs.org/mobx/-/mobx-5.1.0.tgz", - "integrity": "sha512-cQzBmF2gbpcBR2xKwt5jZx0ncDMC9Hg5nYrp3Krv0qHH4GFqWZyR+ZLkRJRcvVF4rqxpy2G96Qbk5YzyQ8tdXw==" + "integrity": "sha512-cQzBmF2gbpcBR2xKwt5jZx0ncDMC9Hg5nYrp3Krv0qHH4GFqWZyR+ZLkRJRcvVF4rqxpy2G96Qbk5YzyQ8tdXw==", + "dev": true }, "mobx-preact": { "version": "3.0.0", "resolved": "https://registry.npmjs.org/mobx-preact/-/mobx-preact-3.0.0.tgz", "integrity": "sha1-aD8YBeRydXDI7OFWGiXzR3O3tgE=", + "dev": true, "requires": { "hoist-non-react-statics": "^2.3.1" } @@ -8362,7 +8367,8 @@ "regenerator-runtime": { "version": "0.11.1", "resolved": "https://registry.npmjs.org/regenerator-runtime/-/regenerator-runtime-0.11.1.tgz", - "integrity": "sha512-MguG95oij0fC3QV3URf4V2SDYGJhJnJGqvIIgdECeODCT98wSWDAJ94SSuVpYQUoTcGUIL6L4yNB7j1DFFHSBg==" + "integrity": "sha512-MguG95oij0fC3QV3URf4V2SDYGJhJnJGqvIIgdECeODCT98wSWDAJ94SSuVpYQUoTcGUIL6L4yNB7j1DFFHSBg==", + "dev": true }, "regenerator-transform": { "version": "0.13.3", diff --git a/package.json b/package.json index 4baf0db7..04591774 100644 --- a/package.json +++ b/package.json @@ -33,7 +33,6 @@ "views" ], "dependencies": { - "@babel/polyfill": "7.0.0", "@babel/runtime": "7.0.0", "acorn": "^5.7.3", "bfj": "^6.1.1", @@ -45,8 +44,6 @@ "gzip-size": "^5.0.0", "lodash": "4.17.10", "mkdirp": "^0.5.1", - "mobx": "5.1.0", - "mobx-preact": "3.0.0", "opener": "^1.5.1", "ws": "^6.0.0" }, @@ -55,6 +52,7 @@ "@babel/plugin-proposal-class-properties": "7.0.0", "@babel/plugin-proposal-decorators": "7.0.0", "@babel/plugin-transform-runtime": "7.0.0", + "@babel/polyfill": "7.0.0", "@babel/preset-env": "7.0.0", "@babel/preset-react": "7.0.0", "@babel/register": "7.0.0", @@ -74,6 +72,8 @@ "exports-loader": "0.7.0", "gulp": "4.0.0", "gulp-babel": "8.0.0", + "mobx": "5.1.0", + "mobx-preact": "3.0.0", "mocha": "5.2.0", "nightmare": "3.0.1", "postcss-icss-values": "2.0.1", From 014ed392eb1e60b4d0ae790747075ed5e22be42b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rouven=20We=C3=9Fling?= Date: Tue, 11 Sep 2018 23:02:26 +0200 Subject: [PATCH 2/4] Use the minimal supported Node version as the babel build target --- .babelrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.babelrc b/.babelrc index 53298dba..162e518d 100644 --- a/.babelrc +++ b/.babelrc @@ -3,7 +3,7 @@ { "presets": [ ["@babel/preset-env", { - "targets": {"node": 6} + "targets": {"node": "6.14.4"} }] ], "plugins": [ From c011b61696aeffc25cdfa3b52c9944baa757577f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rouven=20We=C3=9Fling?= Date: Tue, 11 Sep 2018 23:13:03 +0200 Subject: [PATCH 3/4] Make @babel/runtime a dev dependency The miimal size saving is not worth the extra dependencies --- .babelrc | 3 +-- package-lock.json | 4 +++- package.json | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.babelrc b/.babelrc index 162e518d..9dbbb7f7 100644 --- a/.babelrc +++ b/.babelrc @@ -7,7 +7,6 @@ }] ], "plugins": [ - ["@babel/plugin-proposal-class-properties", {"loose": true}], - "@babel/plugin-transform-runtime" + ["@babel/plugin-proposal-class-properties", {"loose": true}] ] } diff --git a/package-lock.json b/package-lock.json index b7b57d20..ff1fe221 100644 --- a/package-lock.json +++ b/package-lock.json @@ -839,6 +839,7 @@ "version": "7.0.0", "resolved": "https://registry.npmjs.org/@babel/runtime/-/runtime-7.0.0.tgz", "integrity": "sha512-7hGhzlcmg01CvH1EHdSPVXYX1aJ8KCEyz6I9xYIi/asDtzBPMyMhVibhM/K6g/5qnKBwjZtp10bNZIEFTRW1MA==", + "dev": true, "requires": { "regenerator-runtime": "^0.12.0" }, @@ -846,7 +847,8 @@ "regenerator-runtime": { "version": "0.12.1", "resolved": "https://registry.npmjs.org/regenerator-runtime/-/regenerator-runtime-0.12.1.tgz", - "integrity": "sha512-odxIc1/vDlo4iZcfXqRYFj0vpXFNoGdKMAUieAlFYO6m/nl5e9KR/beGf41z4a1FI+aQgtjhuaSlDxQ0hmkrHg==" + "integrity": "sha512-odxIc1/vDlo4iZcfXqRYFj0vpXFNoGdKMAUieAlFYO6m/nl5e9KR/beGf41z4a1FI+aQgtjhuaSlDxQ0hmkrHg==", + "dev": true } } }, diff --git a/package.json b/package.json index 04591774..1f217a92 100644 --- a/package.json +++ b/package.json @@ -33,7 +33,6 @@ "views" ], "dependencies": { - "@babel/runtime": "7.0.0", "acorn": "^5.7.3", "bfj": "^6.1.1", "chalk": "^2.4.1", @@ -56,6 +55,7 @@ "@babel/preset-env": "7.0.0", "@babel/preset-react": "7.0.0", "@babel/register": "7.0.0", + "@babel/runtime": "7.0.0", "babel-eslint": "9.0.0", "babel-loader": "8.0.2", "babel-plugin-lodash": "3.3.4", From ae849d0fef68d2048dd72ec6068b1001fd426ce9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rouven=20We=C3=9Fling?= Date: Tue, 11 Sep 2018 23:16:57 +0200 Subject: [PATCH 4/4] Allow a semver range for lodash --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 1f217a92..0ada2d7a 100644 --- a/package.json +++ b/package.json @@ -41,7 +41,7 @@ "express": "^4.16.3", "filesize": "^3.6.1", "gzip-size": "^5.0.0", - "lodash": "4.17.10", + "lodash": "^4.17.10", "mkdirp": "^0.5.1", "opener": "^1.5.1", "ws": "^6.0.0"