This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
Refactor stuff #333
Merged
Refactor stuff #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooflorent
reviewed
Jul 27, 2018
| @@ -56,8 +54,18 @@ class UglifyJsPlugin { | |||
| }; | |||
| } | |||
|
|
|||
| static isSourceMap(input) { | |||
There was a problem hiding this comment.
I prefer the function as a helper. If you expose it it becomes a public API
There was a problem hiding this comment.
@ooflorent yep, why:
AbstractMinimizerWebpackPlugincan be based on this code and this helper should be public (I'm preparing to release it next week).- We use source map only when we have errors/warnings and all logic for building errors/warnings already inside class (it is also require for
AbstractMinimizerWebpackPlugin).
|
Merge as is, feel free to feedback |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly:
sourceMap.test.js->sourceMap-option.test.js)