Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): add types #477

Merged
merged 3 commits into from Mar 30, 2022

Conversation

harish-sethuraman
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Added proper types

README.md Outdated
Type:

```ts
type minify = function;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-akait I'd need help here to find the type of this minify

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #477 (bef7761) into master (20075bd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #477   +/-   ##
=======================================
  Coverage   97.11%   97.11%           
=======================================
  Files           3        3           
  Lines         312      312           
  Branches      114      114           
=======================================
  Hits          303      303           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20075bd...bef7761. Read the comment docs.

@alexander-akait
Copy link
Member

Please update snapshots

@harish-sethuraman
Copy link
Contributor Author

Please update snapshots

For readme update do we need snapshot update?

@alexander-akait
Copy link
Member

Because deps were update (maybe miss cache on CI, so the latest version was installed for all packages)

@harish-sethuraman
Copy link
Contributor Author

@alexander-akait I ran jest --updateSnapshot but I didn't see any changes in the local? What am I doing wrong? Can you help me out please?

@snitin315
Copy link
Member

@harish-sethuraman try upgrading webpack to the latest version and then update snapshots.

@harish-sethuraman
Copy link
Contributor Author

Done

@harish-sethuraman
Copy link
Contributor Author

Seems like now it is not failing for snapshot but failed due to some other error @alexander-akait

@alexander-akait
Copy link
Member

let's try to regenerate lock file, thanks

@harish-sethuraman
Copy link
Contributor Author

Do you mean we want to delete the existing file and generate a completely new one?

@alexander-akait
Copy link
Member

Looks random fail on CI, don't worry, let's merge

@alexander-akait alexander-akait merged commit 3d6539f into webpack-contrib:master Mar 30, 2022
@alexander-akait
Copy link
Member

Big thanks

@harish-sethuraman
Copy link
Contributor Author

😁

@harish-sethuraman harish-sethuraman deleted the add-types branch March 30, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants