New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(readme): add types #477
docs(readme): add types #477
Conversation
README.md
Outdated
Type: | ||
|
||
```ts | ||
type minify = function; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexander-akait I'd need help here to find the type of this minify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Codecov Report
@@ Coverage Diff @@
## master #477 +/- ##
=======================================
Coverage 97.11% 97.11%
=======================================
Files 3 3
Lines 312 312
Branches 114 114
=======================================
Hits 303 303
Misses 9 9 Continue to review full report at Codecov.
|
Please update snapshots |
For readme update do we need snapshot update? |
Because deps were update (maybe miss cache on CI, so the latest version was installed for all packages) |
@alexander-akait I ran jest --updateSnapshot but I didn't see any changes in the local? What am I doing wrong? Can you help me out please? |
@harish-sethuraman try upgrading webpack to the latest version and then update snapshots. |
Done |
Seems like now it is not failing for snapshot but failed due to some other error @alexander-akait |
let's try to regenerate lock file, thanks |
Do you mean we want to delete the existing file and generate a completely new one? |
Looks random fail on CI, don't worry, let's merge |
Big thanks |
😁 |
This PR contains a:
Motivation / Use-Case
Added proper types