Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove cjs wrapper and improve types format #463

Merged
merged 1 commit into from Dec 16, 2021

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

removed cjs wrapper and generated types in commonjs format (export = and namespaces used in types), now you can directly use exported types

Breaking Changes

Potentially yes, but we use babel and our code in commonjs format, but typescript generate ESM format for declarations, it is bug

Additional Info

No

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #463 (b5f29ad) into master (d5146c9) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
+ Coverage   97.03%   97.11%   +0.07%     
==========================================
  Files           4        3       -1     
  Lines         304      312       +8     
  Branches      114      114              
==========================================
+ Hits          295      303       +8     
  Misses          9        9              
Impacted Files Coverage Δ
src/index.js 97.34% <100.00%> (+0.10%) ⬆️
src/minify.js 100.00% <100.00%> (ø)
src/utils.js 95.00% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5146c9...b5f29ad. Read the comment docs.

@alexander-akait alexander-akait merged commit 34fadde into master Dec 16, 2021
@alexander-akait alexander-akait deleted the feat-remove-cjs-wrapper branch December 16, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant