Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: types for the extractComments option #444

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

based on CI output for webpack

Breaking Changes

No

Additional Info

all options are optional

@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #444 (a6daf7d) into master (c314e33) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #444   +/-   ##
=======================================
  Coverage   97.18%   97.18%           
=======================================
  Files           4        4           
  Lines         284      284           
  Branches      107      107           
=======================================
  Hits          276      276           
  Misses          8        8           
Impacted Files Coverage Δ
src/index.js 96.88% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c314e33...a6daf7d. Read the comment docs.

@alexander-akait alexander-akait merged commit 14e5cbf into master Sep 3, 2021
@alexander-akait alexander-akait deleted the fix-types-for-extract-comments branch September 3, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant