Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve naming of comments extract file #154

Merged

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #152

Breaking Changes

No

Additional Info

See documentation

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #154 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   99.29%   99.32%   +0.03%     
==========================================
  Files           5        5              
  Lines         282      295      +13     
  Branches      111      116       +5     
==========================================
+ Hits          280      293      +13     
  Misses          2        2
Impacted Files Coverage Δ
src/index.js 99.4% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea7243...5768695. Read the comment docs.

@alexander-akait alexander-akait merged commit 5fe3337 into master Sep 12, 2019
@alexander-akait alexander-akait deleted the fix-extract-comments-with-query-string-in-filename branch September 12, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExtractComments fails to extract comments sporadically
1 participant