Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: respect devtool values for source map generation #140

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Sep 5, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Partial #71

Breaking Changes

Yes

Additional Info

No

@alexander-akait alexander-akait merged commit dd37ca1 into master Sep 5, 2019
@alexander-akait alexander-akait deleted the issue-71-next branch September 5, 2019 16:19
wmfgerrit pushed a commit to wikimedia/mediawiki-services-mobileapps that referenced this pull request Mar 13, 2020
The new version of terser-webpack-plugin automatically uses the devtool
setting in the webpack config, so it now creates source maps.[1][2]

[1] https://github.com/webpack-contrib/terser-webpack-plugin/releases/tag/v2.0.0
> * respect devtool values for source map generation (#140) (dd37ca1)
[2] webpack-contrib/terser-webpack-plugin#140

Change-Id: I534ec2fb9e9e3a1a2ea258457868a8be8df72956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant