Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable the cache option by default #132

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

enable the cache option by default

Breaking Changes

Yes

BREAKING CHANGE: the cache option is true by default

Additional Info

No

@alexander-akait alexander-akait force-pushed the feat-enable-the-cache-option-by-default branch 6 times, most recently from aa2359b to f2f5702 Compare September 3, 2019 17:59
@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #132 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files           5        5           
  Lines         291      291           
  Branches      117      117           
=======================================
  Hits          287      287           
  Misses          4        4
Impacted Files Coverage Δ
src/index.js 98.06% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b342af...f2f5702. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #132 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   98.62%   98.63%   +<.01%     
==========================================
  Files           5        5              
  Lines         291      293       +2     
  Branches      117      117              
==========================================
+ Hits          287      289       +2     
  Misses          4        4
Impacted Files Coverage Δ
src/TaskRunner.js 98.03% <100%> (+0.08%) ⬆️
src/index.js 98.06% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b342af...2968bc7. Read the comment docs.

@alexander-akait alexander-akait force-pushed the feat-enable-the-cache-option-by-default branch 5 times, most recently from 383ea63 to 81ac5f0 Compare September 4, 2019 12:06
BREAKING CHANGE: the `cache` option is `true` by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant