Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source map is not working anymore #101

Closed
p3x-robot opened this issue Jun 30, 2019 · 2 comments
Closed

source map is not working anymore #101

p3x-robot opened this issue Jun 30, 2019 · 2 comments

Comments

@p3x-robot
Copy link

Expected Behavior

sourcemaps are working

Actual Behavior

Warning: Command failed: ./node_modules/.bin/webpack-cli --color --cache --production --config /home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/corifeus-builder-angular/src/webpack.test.config.js
6/30/2019, 10:25:55 AM unhandledRejection Error: original.line and original.column are not numbers -- you probably meant to omit the original mapping entirely and only map the generated position. If so, pass null for the original mapping instead of an object with empty or null values.
    at SourceMapGenerator_validateMapping [as _validateMapping] (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack-sources/node_modules/source-map/lib/source-map-generator.js:276:15)
    at SourceMapGenerator_addMapping [as addMapping] (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack-sources/node_modules/source-map/lib/source-map-generator.js:110:12)
    at /home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack-sources/node_modules/source-map/lib/source-map-generator.js:72:17
    at Array.forEach (<anonymous>)
    at BasicSourceMapConsumer.SourceMapConsumer_eachMapping [as eachMapping] (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack-sources/node_modules/source-map/lib/source-map-consumer.js:157:14)
    at Function.SourceMapGenerator_fromSourceMap [as fromSourceMap] (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack-sources/node_modules/source-map/lib/source-map-generator.js:48:24)
    at SourceMapSource.node (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack-sources/lib/SourceMapSource.js:32:35)
    at /home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack-sources/lib/ConcatSource.js:59:50
    at Array.map (<anonymous>)
    at ConcatSource.node (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack-sources/lib/ConcatSource.js:58:63)
    at ConcatSource.proto.sourceAndMap (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack-sources/lib/SourceAndMapMixin.js:30:18)
    at getTaskForFile (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack/lib/SourceMapDevToolPlugin.js:37:30)
    at /home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack/lib/SourceMapDevToolPlugin.js:136:20
    at Array.forEach (<anonymous>)
    at /home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack/lib/SourceMapDevToolPlugin.js:130:12
    at SyncHook.eval [as call] (eval at create (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:7:1)
    at SyncHook.lazyCompileHook (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/tapable/lib/Hook.js:154:20)
    at /home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack/lib/Compilation.js:1315:42
    at eval (eval at create (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:12:1)
    at /home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/terser-webpack-plugin/dist/index.js:319:9
    at step (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/terser-webpack-plugin/dist/TaskRunner.js:87:9)
    at done (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/terser-webpack-plugin/dist/TaskRunner.js:98:30)
    at tryCatcher (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:517:31)
    at Promise._settlePromise (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:574:18)
    at Promise._settlePromise0 (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:619:10)
    at Promise._settlePromises (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:699:18)
    at Promise._fulfill (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:643:18)
    at Promise._resolveCallback (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:437:57)
    at Promise._settlePromiseFromHandler (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:529:17)
    at Promise._settlePromise (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:574:18)
    at Promise._settlePromise0 (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:619:10)
    at Promise._settlePromises (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:699:18)
    at Promise._fulfill (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:643:18)
    at Promise._resolveCallback (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:437:57)
    at Promise._settlePromiseFromHandler (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:529:17) Promise [Object] {
  _bitField: 152305664,
  _fulfillmentHandler0: Error: original.line and original.column are not numbers -- you probably meant to omit the original mapping entirely and only map the generated position. If so, pass null for the original mapping instead of an object with empty or null values.
      at SourceMapGenerator_validateMapping [as _validateMapping] (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack-sources/node_modules/source-map/lib/source-map-generator.js:276:15)
      at SourceMapGenerator_addMapping [as addMapping] (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack-sources/node_modules/source-map/lib/source-map-generator.js:110:12)
      at /home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack-sources/node_modules/source-map/lib/source-map-generator.js:72:17
      at Array.forEach (<anonymous>)
      at BasicSourceMapConsumer.SourceMapConsumer_eachMapping [as eachMapping] (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack-sources/node_modules/source-map/lib/source-map-consumer.js:157:14)
      at Function.SourceMapGenerator_fromSourceMap [as fromSourceMap] (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack-sources/node_modules/source-map/lib/source-map-generator.js:48:24)
      at SourceMapSource.node (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack-sources/lib/SourceMapSource.js:32:35)
      at /home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack-sources/lib/ConcatSource.js:59:50
      at Array.map (<anonymous>)
      at ConcatSource.node (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack-sources/lib/ConcatSource.js:58:63)
      at ConcatSource.proto.sourceAndMap (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack-sources/lib/SourceAndMapMixin.js:30:18)
      at getTaskForFile (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack/lib/SourceMapDevToolPlugin.js:37:30)
      at /home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack/lib/SourceMapDevToolPlugin.js:136:20
      at Array.forEach (<anonymous>)
      at /home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack/lib/SourceMapDevToolPlugin.js:130:12
      at SyncHook.eval [as call] (eval at create (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:7:1)
      at SyncHook.lazyCompileHook (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/tapable/lib/Hook.js:154:20)
      at /home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/webpack/lib/Compilation.js:1315:42
      at eval (eval at create (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:12:1)
      at /home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/terser-webpack-plugin/dist/index.js:319:9
      at step (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/terser-webpack-plugin/dist/TaskRunner.js:87:9)
      at done (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/terser-webpack-plugin/dist/TaskRunner.js:98:30)
      at tryCatcher (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/util.js:16:23)
      at Promise._settlePromiseFromHandler (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:517:31)
      at Promise._settlePromise (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:574:18)
      at Promise._settlePromise0 (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:619:10)
      at Promise._settlePromises (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:699:18)
      at Promise._fulfill (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:643:18)
      at Promise._resolveCallback (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:437:57)
      at Promise._settlePromiseFromHandler (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:529:17)
      at Promise._settlePromise (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:574:18)
      at Promise._settlePromise0 (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:619:10)
      at Promise._settlePromises (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:699:18)
      at Promise._fulfill (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:643:18)
      at Promise._resolveCallback (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:437:57)
      at Promise._settlePromiseFromHandler (/home/patrikx3/Projects/patrikx3/corifeus/corifeus-web/node_modules/bluebird/js/release/promise.js:529:17),
  _rejectionHandler0: undefined,
  _promise0: undefined,
  _receiver0: undefined
}

Code

// webpack.config.js
// If your code blocks are over 20 lines, please paste a link to a gist
// (https://gist.github.com).
      commonConfig.optimization.minimizer = [
            new TerserPlugin({
                //FIXME sourcemap is not working since 8.0.3
                sourceMap: true,
                parallel: true,
                cache: true,
                extractComments: {
                    condition: /^\**!|@preserve|@license|@cc_on/,

                    filename: function (fileName) {
                        return `${fileName}.LICENSE.txt`;
                    },
                    banner: function (webpackBanner) {
                        return `
${bannerText}
For more information about all licenses, please see ${webpackBanner}
`;
                    }
                },
                terserOptions: {
                    compress: {
                        warnings: false
                    },
                    ecma: 8,
                    // todo found out if mangle use or not
                    // mangle: false === keep function names
                    // mangle: true === drop function names
                    mangle: false,
                    comments: false,
                    beautify: false
                },
            }),
        ]

How Do We Reproduce?

the problem is, that some repos i can build with sourcemap, in other repos i have to disable the sourcemap.

@alexander-akait
Copy link
Member

Close in favor #100, please create minimum reproducible test repo in original issue

@p3x-robot
Copy link
Author

p3x-robot commented Jul 1, 2019

here is the the error:

git clone https://github.com/patrikx3/redis-ui-material
npm install
# now in the src/builder/webpack.config.js file, rename sourceMap: false to sourceMap: true
# and there are you with the error
npm run build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants