Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: insert option #413

Merged
merged 1 commit into from Aug 2, 2019
Merged

refactor: insert option #413

merged 1 commit into from Aug 2, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Implement insert option for custom insert logic

Breaking Changes

Yes

BREAKING CHANGE: insertAt and insertInto option was removed in favor insert option (please look docs and examples)

Additional Info

We still doesn't recommended use non standard behavior

BREAKING CHANGE: `insertAt` and `insertInto` option was removed in favor `insert` option (please look docs and examples)
@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #413 into master will increase coverage by 2.38%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #413      +/-   ##
========================================
+ Coverage   97.61%   100%   +2.38%     
========================================
  Files           3      3              
  Lines         210    200      -10     
  Branches       71     72       +1     
========================================
- Hits          205    200       -5     
+ Misses          4      0       -4     
+ Partials        1      0       -1
Impacted Files Coverage Δ
src/runtime/injectStylesIntoStyleTag.js 100% <100%> (+0.62%) ⬆️
src/index.js 100% <100%> (ø) ⬆️
src/runtime/injectStylesIntoLinkTag.js 100% <100%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7ed255...21f030c. Read the comment docs.

@alexander-akait alexander-akait merged commit 0bb8ded into master Aug 2, 2019
@alexander-akait alexander-akait deleted the refactor-insert-option branch August 2, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant