fix(index): handle exception on loading invalid source maps (#65) #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alexander-akait
requested changes
Jul 12, 2018
|
@jsf-clabot | @evilebottnawi | anyone else |
|
Or I could just move the addDependency() call into the try? |
|
I figured that since the dependency isn't removed if there's an error reading the file, then I don't need to worry about it. |
alexander-akait
approved these changes
Jul 18, 2018
michael-ciniawsky
pushed a commit
that referenced
this pull request
Aug 14, 2018
|
Released in |
michael-ciniawsky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a try catch that's pretty much the same as the base64 fix.