Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: updates dependencies to fix CVE-2015-8315 #62

Merged
merged 5 commits into from
Apr 30, 2018
Merged

refactor: updates dependencies to fix CVE-2015-8315 #62

merged 5 commits into from
Apr 30, 2018

Conversation

shellscape
Copy link
Contributor

@shellscape shellscape commented Apr 8, 2018 •
edited by joshwiens 

BREAKING CHANGE: Enforces `engines` of `"node": ">= 8.9.0"`

BREAKING CHANGE: Updates to `source-map@^0.7.2` which requires NodeJS >= 8

BREAKING CHANGE: Updates to `loader-utils@^1.1.0` &  `loderUtils.getOptions`

alexander-akait
alexander-akait reviewed Apr 9, 2018
View reviewed changes
package.json Outdated
"loader-utils": "~0.2.2",
"source-map": "~0.6.1"
"loader-utils": "^1.1.0",
"source-map": "^0.7.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw for source-map@7 and above.

Breaking change: Drop support for Node < 8. If you want to support older versions of node, please use v0.6 or below.

Looks like breaking change for loader

joshwiens
joshwiens approved these changes Apr 16, 2018
View reviewed changes
Copy link
Member

@joshwiens joshwiens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking w/ the loader-utils upgrade as well

@joshwiens joshwiens changed the title fix(security): updates dependencies to fix CVE-2015-8315 refactor: updates dependencies to fix CVE-2015-8315 Apr 18, 2018
@joshwiens joshwiens mentioned this pull request Apr 18, 2018
Closed
joshwiens
joshwiens requested changes Apr 30, 2018
View reviewed changes
Copy link
Member

@joshwiens joshwiens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to set engines to Minimum of Node 8.9.0

@joshwiens
chore(package): Enforces engines inline with source-map node 8 requir…
c47798e 
…ement

BREAKING CHANGE: Enforces `engines` of `"node": ">= 8.9.0"`
@joshwiens
ci(travis): Drop Node 6 from test matrix
444afb3 
 - source-map@0.7 supports Node > 8
@joshwiens joshwiens merged commit ac30677 into master Apr 30, 2018
@joshwiens joshwiens deleted the fix/security branch April 30, 2018 12:33
michael-ciniawsky pushed a commit that referenced this pull request Aug 14, 2018
@shellscape @michael-ciniawsky
refactor(package): updates dependencies to fix CVE-2015-8315 (#62)
7843bb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@ooflorent ooflorent ooflorent approved these changes

@sokra sokra sokra approved these changes

@joshwiens joshwiens joshwiens approved these changes

Assignees
No one assigned
Labels
semver: Major status: Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shellscape @ooflorent @sokra @alexander-akait @joshwiens