Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compatibility with the filesystem cache #896

Merged
merged 3 commits into from Oct 22, 2020

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Oct 22, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Complex bug:

  • we should skip resolving for empty possible requests, because it makes no sense and reduce performance
  • it breaks file system cache with ugly error

Breaking Changes

No

Additional Info

Updating deps too

@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #896 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
+ Coverage   95.96%   96.01%   +0.05%     
==========================================
  Files           4        4              
  Lines         223      226       +3     
  Branches       71       72       +1     
==========================================
+ Hits          214      217       +3     
  Misses          8        8              
  Partials        1        1              
Impacted Files Coverage Δ
src/utils.js 95.21% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b378046...b4743f9. Read the comment docs.

@alexander-akait alexander-akait changed the title Chore deps update fix compatibility with the filesystem cache Oct 22, 2020
@alexander-akait alexander-akait merged commit e31f9b6 into master Oct 22, 2020
@alexander-akait alexander-akait deleted the chore-deps-update branch October 22, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant