Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace clone-deep with smaller klona #857

Merged
merged 1 commit into from Jul 3, 2020

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Jul 2, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation

Bloated node_modules with ton of packages.

Klona has no dependencies and the package is smaller.
https://packagephobia.com/result?p=klona
https://packagephobia.com/result?p=clone-deep

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #857 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #857   +/-   ##
=======================================
  Coverage   97.90%   97.90%           
=======================================
  Files           4        4           
  Lines         191      191           
  Branches       63       63           
=======================================
  Hits          187      187           
  Misses          4        4           
Impacted Files Coverage Δ
src/utils.js 97.38% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45bd865...e147892. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I will migrate on klona in other loaders/plugins where we use clone-deep, thanks

@alexander-akait alexander-akait merged commit 9a16432 into webpack-contrib:master Jul 3, 2020
@TrySound TrySound deleted the klona branch July 3, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants