Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: overhaul readme #771

Merged
merged 1 commit into from Oct 8, 2019

Conversation

madflow
Copy link
Contributor

@madflow madflow commented Oct 8, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

This PR tries to make the README a more pleasant read.

  • Added YARN setup
  • Webpack as proper nount
  • sass-loader whenever it is used
  • Some small fixes with good intentions

@jsf-clabot
Copy link

jsf-clabot commented Oct 8, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #771 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #771   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files          10       10           
  Lines         178      178           
  Branches       63       63           
=======================================
  Hits          174      174           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 185ba80...051efda. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, remove yarn section from this PR, we use template for README and need added this section in template (improve all readme in future)

@madflow
Copy link
Contributor Author

madflow commented Oct 8, 2019

Done and rebased.

@alexander-akait
Copy link
Member

Thanks for PR, good job!

@alexander-akait alexander-akait merged commit 6d11b7b into webpack-contrib:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants