Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefer sass/scss/css extensions #711

Merged
merged 1 commit into from Aug 8, 2019
Merged

fix: prefer sass/scss/css extensions #711

merged 1 commit into from Aug 8, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #556

Breaking Changes

Should be no, but if you faced with problem feel free to open new issue

Additional Info

No

@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #711 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   98.06%   98.07%   +0.01%     
==========================================
  Files           6        6              
  Lines         155      156       +1     
==========================================
+ Hits          152      153       +1     
  Misses          3        3
Impacted Files Coverage Δ
lib/loader.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28f1884...dada514. Read the comment docs.

@alexander-akait alexander-akait merged commit 6fc9d4e into master Aug 8, 2019
@alexander-akait alexander-akait deleted the issue-556 branch August 8, 2019 16:43
@alexander-akait
Copy link
Member Author

may i ask what the '...' additions mean (here and the line below)?

it extends you default configuration, you can use global mainFields https://webpack.js.org/configuration/resolve/#resolvemainfields, to avoid break logic we just extends them

does this change mean i can use the "style" field in package.json?

yes, you can use sass and/or style field in package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import prefer js over css/sass/scss
1 participant