chore: remove fibers package #1059
Conversation
Fibers package is deprecated.
Codecov Report
@@ Coverage Diff @@
## master #1059 +/- ##
=======================================
Coverage 94.33% 94.33%
=======================================
Files 5 5
Lines 371 371
Branches 137 137
=======================================
Hits 350 350
Misses 19 19
Partials 2 2 Continue to review full report at Codecov.
|
|
Codecov seems to be failing. I am not able to view line-by-line coverage for the utils file.
|
package.json
Outdated
| @@ -38,7 +38,6 @@ | |||
| "dist" | |||
| ], | |||
| "peerDependencies": { | |||
| "fibers": ">= 3.1.0", | |||
There was a problem hiding this comment.
Don't remove it from here, we still need to continue support (otherwise it will be breaking change), just improve readme about deprection
There was a problem hiding this comment.
sure. I will update readme and revert other changes
There was a problem hiding this comment.
done. Pls let me know any changes required
|
Bumping for review. |
README.md
Outdated
| @@ -244,7 +244,8 @@ To avoid this overhead, you can use the [fibers](https://www.npmjs.com/package/f | |||
|
|
|||
| We automatically inject the [`fibers`](https://github.com/laverdet/node-fibers) package (setup `sassOptions.fiber`) for `Node.js` less v16.0.0 if is possible (i.e. you need install the [`fibers`](https://github.com/laverdet/node-fibers) package). | |||
|
|
|||
| > Fibers is not compatible with `Node.js` v16.0.0 or later ([see introduction to readme](https://github.com/laverdet/node-fibers)). | |||
| > ⚠ Fibers is not compatible with `Node.js` v16.0.0 or later. Unfortunately, v8 | |||
| > commit [dacc2fee0f](https://github.com/v8/v8/commit/dacc2fee0f815823782a7e432c79c2a7767a4765) is a breaking change and workarounds are non-trivial. ([see introduction to readme](https://github.com/laverdet/node-fibers)). | |||
There was a problem hiding this comment.
Can we use the latest supported syntax here, i.e.
> **Warning**
>
> Warning Text
This PR contains a:
Motivation / Use-Case
Remove fibers