Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the "implementation" option #533

Merged
merged 1 commit into from
Jun 13, 2021

Conversation

meteorlxy
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

The implementation option is missing in the options table

Breaking Changes

Additional Info

@codecov
Copy link

codecov bot commented Jun 12, 2021

Codecov Report

Merging #533 (428a5b5) into master (bd26187) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #533   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files           5        5           
  Lines         308      308           
  Branches       97       97           
=======================================
  Hits          288      288           
  Misses         18       18           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd26187...428a5b5. Read the comment docs.

@alexander-akait
Copy link
Member

@meteorlxy Can you accept CLA?

@meteorlxy
Copy link
Contributor Author

@alexander-akait Sorry, didn't notice that. Have signed now.

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snitin315 snitin315 merged commit 14f83a0 into webpack-contrib:master Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants