Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Node.js v10 dropped #526

Merged
merged 6 commits into from Jun 10, 2021
Merged

refactor: Node.js v10 dropped #526

merged 6 commits into from Jun 10, 2021

Conversation

cap-Bernardito
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Support Node.js 10 dropped

Breaking Changes

Support Node.js 10 dropped

Additional Info

No

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #526 (07acfe4) into master (c715df2) will decrease coverage by 1.68%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #526      +/-   ##
==========================================
- Coverage   94.93%   93.24%   -1.69%     
==========================================
  Files           5        5              
  Lines         296      296              
  Branches       96       95       -1     
==========================================
- Hits          281      276       -5     
- Misses         14       18       +4     
- Partials        1        2       +1     
Impacted Files Coverage Δ
src/utils.js 89.52% <0.00%> (-2.66%) ⬇️
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c715df2...07acfe4. Read the comment docs.

@cap-Bernardito cap-Bernardito force-pushed the node-dropped branch 5 times, most recently from 3ee6d21 to 7138c50 Compare May 14, 2021 13:54
@cap-Bernardito cap-Bernardito changed the title chore(deps): node 10 dropped refactor: Node.js v10 dropped May 18, 2021
snitin315
snitin315 previously approved these changes Jun 10, 2021
anshumanv
anshumanv previously approved these changes Jun 10, 2021
@alexander-akait alexander-akait dismissed stale reviews from anshumanv and snitin315 via f318a0c June 10, 2021 14:49
@alexander-akait alexander-akait merged commit a69cc1d into master Jun 10, 2021
@alexander-akait alexander-akait deleted the node-dropped branch June 10, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants