fix: do not attempt hotreloading when emit is false #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ntucker
commented
Jun 15, 2022
| @@ -69,6 +69,7 @@ function hotLoader(content, context) { | |||
| function pitch(request) { | |||
| // @ts-ignore | |||
| const options = this.getOptions(/** @type {Schema} */ (schema)); | |||
| const emit = typeof options.emit !== "undefined" ? options.emit : true; | |||
There was a problem hiding this comment.
hoisted this so we can access it in the hot reloading path
ntucker
force-pushed
the
no-ssr-warning-spam
branch
from
94c4d25
to
a2742f1
Compare
Codecov Report
@@ Coverage Diff @@
## master #953 +/- ##
==========================================
+ Coverage 89.73% 90.34% +0.61%
==========================================
Files 5 5
Lines 828 829 +1
Branches 221 221
==========================================
+ Hits 743 749 +6
+ Misses 74 70 -4
+ Partials 11 10 -1
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Jun 15, 2022
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Fixes #943
When doing SSR it is desirable to still run the same css pipeline so consistent hashes can be produced in the SSR code. However, actually emitting the CSS is unnecessary. Because of this it is custom to set emit to false. In this case, it would be nice to not have
no window.document found, will not HMR CSSspamming the console as well as same some small computational time.Breaking Changes
Additional Info