docs(readme): add types #903
Conversation
README.md
Outdated
| Type: | ||
|
|
||
| ```ts | ||
| type insert = string | ((linkTag: any) => void); |
There was a problem hiding this comment.
Please avoid using any, if you found it in our code, it means bug, we should improve this type
There was a problem hiding this comment.
The linkTag here is an HTMLElement right?
There was a problem hiding this comment.
I don't know, but mostly yes, just check it
There was a problem hiding this comment.
Changed to HTMLLinkElement
| or | ||
|
|
||
| ```console | ||
| yarn add -D mini-css-extract-plugin |
There was a problem hiding this comment.
Change it on npm, because we use npm
There was a problem hiding this comment.
If we want to provide yarn, we should also provide pnpm example, i.e. for all package managers
There was a problem hiding this comment.
🤔 I've seen npm and yarn in some repos. That is why I started adding yarn in all repos. Should we consider adding pnpm as well?
There was a problem hiding this comment.
If we add yarn we should add pnpm too
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
=======================================
Coverage 90.29% 90.29%
=======================================
Files 5 5
Lines 824 824
Branches 220 220
=======================================
Hits 744 744
Misses 70 70
Partials 10 10
Continue to review full report at Codecov.
|
|
Thanks |
This PR contains a:
Motivation / Use-Case
Added types in Readme