Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publicPath auto #709

Merged
merged 1 commit into from Feb 25, 2021
Merged

fix: publicPath auto #709

merged 1 commit into from Feb 25, 2021

Conversation

cap-Bernardito
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fixed #707

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #709 (90b84d6) into master (470ba0e) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
+ Coverage   89.52%   89.58%   +0.05%     
==========================================
  Files           6        6              
  Lines         764      768       +4     
  Branches      228      232       +4     
==========================================
+ Hits          684      688       +4     
  Misses         77       77              
  Partials        3        3              
Impacted Files Coverage Δ
src/loader.js 92.41% <100.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 470ba0e...383e538. Read the comment docs.

@alexander-akait alexander-akait merged commit 1be21d2 into master Feb 25, 2021
@alexander-akait alexander-akait deleted the fix-publickpath-auto branch February 25, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using url() in CSS requires publicPath to be set with Webpack 5
2 participants