Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): fix code comment in extracting css for recursiveissuer #697

Merged

Conversation

maddhruv
Copy link
Contributor

@maddhruv maddhruv commented Feb 6, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

In recursiveIssuer the issuer variable is to be set to m.issuer for webpack 4 at https://webpack.js.org/plugins/mini-css-extract-plugin/#extracting-css-based-on-entry

Breaking Changes

Additional Info

@codecov
Copy link

codecov bot commented Feb 6, 2021

Codecov Report

Merging #697 (b994924) into master (6525c66) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #697   +/-   ##
=======================================
  Coverage   88.93%   88.93%           
=======================================
  Files          11       11           
  Lines         696      696           
  Branches      194      194           
=======================================
  Hits          619      619           
  Misses         74       74           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6525c66...5a58882. Read the comment docs.

@alexander-akait
Copy link
Member

Please accept CLA

@maddhruv
Copy link
Contributor Author

maddhruv commented Feb 8, 2021

Accepted the CLA but seems like one of the other test suites is still failing

@alexander-akait alexander-akait merged commit 030c4d3 into webpack-contrib:master Feb 8, 2021
@maddhruv maddhruv deleted the docs/fix-code-comment branch February 8, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants