Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: improved webpack version check #638

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

cap-Bernardito
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fixes #600

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #638 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #638      +/-   ##
==========================================
+ Coverage   89.48%   89.55%   +0.06%     
==========================================
  Files          11       11              
  Lines         647      651       +4     
  Branches      177      181       +4     
==========================================
+ Hits          579      583       +4     
  Misses         65       65              
  Partials        3        3              
Impacted Files Coverage Δ
src/index.js 91.35% <100.00%> (+0.07%) ⬆️
src/loader.js 92.03% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd7e0ba...a09a4ba. Read the comment docs.

@alexander-akait alexander-akait merged commit 60c3eef into master Oct 23, 2020
@alexander-akait alexander-akait deleted the fix-checking-webpack-version branch October 23, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpackVersion check doesn't work if multiple versions of webpack are in use
2 participants