Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore modules without identifier #627

Merged
merged 2 commits into from Oct 19, 2020
Merged

fix: ignore modules without identifier #627

merged 2 commits into from Oct 19, 2020

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #205

Breaking Changes

No

Additional Info

there may edge cases, feel free to open a new issue, if you faced with this problem

@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #627 into master will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
+ Coverage   88.74%   88.96%   +0.21%     
==========================================
  Files          10       10              
  Lines         613      616       +3     
  Branches      160      161       +1     
==========================================
+ Hits          544      548       +4     
+ Misses         66       65       -1     
  Partials        3        3              
Impacted Files Coverage Δ
src/loader.js 91.89% <100.00%> (+1.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 028b4f2...693185a. Read the comment docs.

@alexander-akait alexander-akait merged commit 71a9ce9 into master Oct 19, 2020
@alexander-akait alexander-akait deleted the issue-205 branch October 19, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'split' of undefined
1 participant