Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error when reloading async chunk #633

Merged
merged 1 commit into from Oct 21, 2020
Merged

Conversation

cap-Bernardito
Copy link
Member

@cap-Bernardito cap-Bernardito commented Oct 21, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fixes #531
Fixes #444

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #633 into master will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
+ Coverage   89.34%   89.53%   +0.18%     
==========================================
  Files          11       11              
  Lines         638      640       +2     
  Branches      168      169       +1     
==========================================
+ Hits          570      573       +3     
+ Misses         65       64       -1     
  Partials        3        3              
Impacted Files Coverage Δ
src/hmr/hotModuleReplacement.js 91.81% <100.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ec95b...f5a31fe. Read the comment docs.

@alexander-akait alexander-akait merged commit 89e7a0a into master Oct 21, 2020
@alexander-akait alexander-akait deleted the fix-error-hmr branch October 21, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HMR: inferring script source from moduleId is not reliable and don't work with [hash]/[fullhash]
2 participants